Log warning of dropped updates to existing resources in policy POST #2944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
This PR reinstates changes committed in #2888 and reverted in #2940.
Additive policy loads (those that use
POST
) currently has unexpected behavior. If a policy POST attempts to update an existing resource, the attempted update is silently discarded.From #2888:
#2888 includes a new error, raised when the
Loader::Orchastrate
finds itself eliminating non-exact duplicates in additive policy operations.#2940 reverts these changes to avoid:
Implemented Changes
Reinstate the changes made in Spike: adding/updating annotations via PUT/POST/PATCH #2888.
Log a descriptive warning instead of raising an error. Example message:
Method
Loader::Orchastrate.detect_duplicates_pk
, which returns a hash of tables to updated resources, and is only invokes by additive policy operations.Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security